[FIX #259] use custom types when importing from postgresql #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no longer defaults to blob
|
@csc530 is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
used prettier for formatting as per contributing.md the type/enum check is case sensitive as there is no way I found to verify if the type was declared in quotes (case-sensitive) or without (to-lowercase by postgres)
csc530
force-pushed
the
259-postgres-enum
branch
from
f3d6219 to
965d1bb
Compare
csc530
changed the title
csc530
changed the title
This was referenced Oct 21, 2024
1ilit
force-pushed
the
main
branch
2 times, most recently
from
0ca7470 to
d389c28
Compare
|
@1ilit sorry for ping, I'm not an author of the this PR, but as a user want this to be implemented. Can you review please? |
1ilit
force-pushed
the
259-postgres-enum
branch
from
c5d35dc to
965d1bb
Compare
1ilit
approved these changes
Mar 20, 2025
ewqazxc
pushed a commit
to ewqazxc/drawdb
that referenced
this pull request
Mar 21, 2025
* 🐛 add custom enums or types when importing from postgresql no longer defaults to blob * allow for quoted enum/types to be correctly imported used prettier for formatting as per contributing.md the type/enum check is case sensitive as there is no way I found to verify if the type was declared in quotes (case-sensitive) or without (to-lowercase by postgres)
1ilit
pushed a commit
that referenced
this pull request
Apr 12, 2025
* 🐛 add custom enums or types when importing from postgresql no longer defaults to blob * allow for quoted enum/types to be correctly imported used prettier for formatting as per contributing.md the type/enum check is case sensitive as there is no way I found to verify if the type was declared in quotes (case-sensitive) or without (to-lowercase by postgres)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #259 and allows for composite types to be imported as well.
I tested this against #259 SQL file and test.sql.txt
again let me know if any changes need to be made there are any issues or test cases that should be considered :)
related issues I discovered
I'll look into fixing these in a separate pr, probably